Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make link cell types customizable #2256

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

GeorgeDT
Copy link
Contributor

@GeorgeDT GeorgeDT commented Jan 11, 2024

This is intended to address the feature request #2255

The old behavior as well as the new behavior are tested.

E.g. the following two scale data grid columns are defined:

    {
      type: 'link',
      label: 'Produkt',
    },
    {
      type: 'link',
      label: 'Edition',
    }

And now we can add the rows like this:

data.push(
  `https://products.telekom.de/?productId=${product.id}`,
  {text: edition.name, href:`?productId=${product.id}`}
)

Which then looks like this:
image

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 6556a15
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/65a53407d237790008cf5ebf
😎 Deploy Preview https://deploy-preview-2256--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@felix-ico
Copy link
Collaborator

hi @GeorgeDT, i tested the changes locally and it looks good to me. Could you run yarn format and commit the output so that prettier CI job passes?

@felix-ico
Copy link
Collaborator

Thank you @GeorgeDT!

@felix-ico felix-ico merged commit a6a03d5 into telekom:main Jan 15, 2024
11 of 12 checks passed
@GeorgeDT
Copy link
Contributor Author

@felix-ico, thank you very much.

@GeorgeDT GeorgeDT deleted the feat/customizable-link-cell branch January 16, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants