Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dockerfile #21

Closed
wants to merge 4 commits into from
Closed

feat: dockerfile #21

wants to merge 4 commits into from

Conversation

y-eight
Copy link
Member

@y-eight y-eight commented Nov 28, 2023

Motivation

Prepared Dockerfile for building the sparrow image.

Changes

For additional information look at the commits.

@y-eight y-eight self-assigned this Nov 28, 2023
Dockerfile Outdated Show resolved Hide resolved
@y-eight y-eight requested a review from lvlcn-t November 30, 2023 07:33
@niklastreml
Copy link
Collaborator

Scratch images come without certificates, please add them to the runner image, otherwise we won't be able to use https:

FROM alpine:latest as certs
RUN apk add --no-cache ca-certificates
...
# In your runner image
COPY --from=certs /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/

@y-eight
Copy link
Member Author

y-eight commented Nov 30, 2023

Ive added the ca certs directly from gobuild stage

Copy link
Collaborator

@puffitos puffitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike having a variable go version (we don't have to abstract/ leave everything to the pipeline), but other than that, lgtm.

Dockerfile Outdated Show resolved Hide resolved
@y-eight
Copy link
Member Author

y-eight commented Nov 30, 2023

I dislike having a variable go version (we don't have to abstract/ leave everything to the pipeline), but other than that, lgtm.

I have chaged it for now. I currently try to use goreleaser to build and release the image. Due to that the Dockerfile might change anyway because the goreleaser builds first (outside the docker context) and just copies the binary to the image.

@y-eight y-eight closed this Nov 30, 2023
@lvlcn-t lvlcn-t added the feature Introduces a new feature label Dec 6, 2023
@lvlcn-t lvlcn-t deleted the ci/image branch December 6, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants