-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dockerfile #21
feat: dockerfile #21
Conversation
Scratch images come without certificates, please add them to the runner image, otherwise we won't be able to use https: FROM alpine:latest as certs
RUN apk add --no-cache ca-certificates
...
# In your runner image
COPY --from=certs /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ |
Ive added the ca certs directly from gobuild stage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike having a variable go version (we don't have to abstract/ leave everything to the pipeline), but other than that, lgtm.
I have chaged it for now. I currently try to use goreleaser to build and release the image. Due to that the Dockerfile might change anyway because the goreleaser builds first (outside the docker context) and just copies the binary to the image. |
Motivation
Prepared Dockerfile for building the
sparrow
image.Changes
For additional information look at the commits.