Reuse, SPDX, Licenses #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-eight
requested review from
niklastreml,
puffitos and
lvlcn-t
as code owners
lvlcn-t
reviewed
Jan 20, 2025
|
Rdy for review. Most of the changes will add the license header. It can be roughly skipped. |
puffitos
reviewed
Jan 23, 2025
Comment on lines
+7
to
+25
| [[annotations]] | ||
| path = [ | ||
| ".idea/**", | ||
| ".vscode/**", | ||
| "**moq.go", | ||
| "docs/**", | ||
| "go.sum" | ||
| ] | ||
| precedence = "aggregate" | ||
| SPDX-FileCopyrightText = "Deutsche Telekom IT GmbH" | ||
| SPDX-License-Identifier = "Apache-2.0" | ||
|
|
||
| [[annotations]] | ||
| path = [ | ||
| "docs/**" | ||
| ] | ||
| precedence = "aggregate" | ||
| SPDX-FileCopyrightText = "Deutsche Telekom IT GmbH" | ||
| SPDX-License-Identifier = "CC-BY-4.0" |
There was a problem hiding this comment.
docs/** is included in both types of licences - how does this work? Docs should typically only have the creative commons licence added (which is the case in this repo). Is this a case of misconfiguration that works out in the end?
puffitos
reviewed
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Last step to stay compliant with Telekom org, we are switching to use
reusecli tool to handle the licenses management with SPDX standard.S11reuseand licence handlingChanges
Adding SPDX headers in all files. For those files that are generated, binary files, etc. a
.licensefile is created. All done byreusetoolset.For additional information look at the commits.
Tests done
TODO