Fix regression: not respecting interval in read_with_poll #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression happened in the port to PL/pgSQL. Division of integers on postgres yields integer results. Our unit conversion from milliseconds to seconds didn't consider that, then returning wrong results. This caused `pgmq.read_with_poll` to sleep 0s instead of `poll_interval_ms` if `poll_interval_ms` was under 1000, using 100% of CPU. The fix is simply converting `poll_interval_ms` to `numeric` before doing the division, which produces a `numeric` result as originally intended.
ChuckHend
approved these changes
Nov 15, 2024
ChuckHend
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Fix regression: not respecting interval in read_with_poll The regression happened in the port to PL/pgSQL. Division of integers on postgres yields integer results. Our unit conversion from milliseconds to seconds didn't consider that, then returning wrong results. This caused `pgmq.read_with_poll` to sleep 0s instead of `poll_interval_ms` if `poll_interval_ms` was under 1000, using 100% of CPU. The fix is simply converting `poll_interval_ms` to `numeric` before doing the division, which produces a `numeric` result as originally intended. * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression happened in the port to PL/pgSQL.
Division of integers on postgres yields integer results. Our unit conversion from milliseconds to seconds didn't consider that, and returned wrong results. This caused
pgmq.read_with_pollto sleep 0s instead ofpoll_interval_msifpoll_interval_mswas under 1000, using 100% of CPU.The fix is simply converting
poll_interval_mstonumericbefore doing the division, which produces anumericresult as originally intended.