Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgmq-python: explicitly cast types #365

Merged
merged 4 commits into from
Dec 19, 2024
Merged

pgmq-python: explicitly cast types #365

merged 4 commits into from
Dec 19, 2024

Conversation

ChuckHend
Copy link
Member

@ChuckHend ChuckHend commented Dec 19, 2024 •
edited
Loading

  • add types for all calls to read and send*
  • run the python client CI when there's changes to the core extension. This should help us more quickly identify when changes to the extension have impact on a client library

@ChuckHend ChuckHend mentioned this pull request Dec 19, 2024
Open
@ChuckHend ChuckHend marked this pull request as ready for review December 19, 2024 18:26
@ChuckHend ChuckHend merged commit 05f27a7 into main Dec 19, 2024
4 checks passed
@ChuckHend ChuckHend deleted the py/explicit-type branch December 19, 2024 18:28
@ChuckHend ChuckHend changed the title pgmq-python: explicitly cast types in send_batch pgmq-python: explicitly cast types Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v0idpwn v0idpwn v0idpwn approved these changes

@theory theory Awaiting requested review from theory theory is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChuckHend @v0idpwn