-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test workflow with unittest #189
base: master
Are you sure you want to change the base?
Add test workflow with unittest #189
Conversation
|
||
jobs: | ||
unit-tests: | ||
if: github.actor != 'copybara-service[bot]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we skip this on this bot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testing workflow was configured this way for TFX, and I copied it here.
If we can justify removing that condition, I'm happy to do so.
@embr do you have an opinion here?
|
||
strategy: | ||
matrix: | ||
python-version: ['3.9', '3.10'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at README.md
looks like 3.11
is also supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vaguely remember an issue with 3.11. I just added it, so we'll see what happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing probably because 3.11 would require different version of protobuf-compiler
, similar to the different versions of library specified here:
Line 308 in 7a068ec
'protobuf>=3.20.3,<5;python_version<"3.11"', |
but, either ways it's okay to skip 3.11 in this PR and can be handled later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's okay to skip 3.11 in this PR and can be handled later.
I'd rather do this than try to make 3.11 work in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the nitpicks, it looks good to me.
@embr This PR seems to me to be ready for review and merge. It just adds a testing workflow. I think fixing the failing tests can come from subsequent work. The test failure is because of an import error. The import refers to code that is "in maintenance mode" and "not available in TFMA OSS". Until the code becomes present in |
Changes in this PR:
.gitignore
fileunittest
skip
s orexpectedFailure
s to tests with errors and failures, respectivelyYou can get a list of tests with
skip
s orexpectedFailure
s using$ grep -nr "PR 189" tensorflow_model_analysis
There is one import error that I have not dealt with.