Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test workflow with unittest #189

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

smokestacklightnin
Copy link

@smokestacklightnin smokestacklightnin commented Oct 23, 2024

Changes in this PR:

  • Add .gitignore file
  • Add unit test GitHub workflow
  • Add unittest skips or expectedFailures to tests with errors and failures, respectively

You can get a list of tests with skips or expectedFailures using

$ grep -nr "PR 189" tensorflow_model_analysis

There is one import error that I have not dealt with.

@smokestacklightnin smokestacklightnin self-assigned this Oct 23, 2024

jobs:
unit-tests:
if: github.actor != 'copybara-service[bot]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we skip this on this bot?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing workflow was configured this way for TFX, and I copied it here.

If we can justify removing that condition, I'm happy to do so.

@embr do you have an opinion here?


strategy:
matrix:
python-version: ['3.9', '3.10']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at README.md looks like 3.11 is also supported?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely remember an issue with 3.11. I just added it, so we'll see what happens

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing probably because 3.11 would require different version of protobuf-compiler, similar to the different versions of library specified here:

'protobuf>=3.20.3,<5;python_version<"3.11"',

but, either ways it's okay to skip 3.11 in this PR and can be handled later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okay to skip 3.11 in this PR and can be handled later.

I'd rather do this than try to make 3.11 work in this PR

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nitpicks, it looks good to me.

@smokestacklightnin
Copy link
Author

smokestacklightnin commented Oct 24, 2024

@embr This PR seems to me to be ready for review and merge. It just adds a testing workflow. I think fixing the failing tests can come from subsequent work.

The test failure is because of an import error. The import refers to code that is "in maintenance mode" and "not available in TFMA OSS". Until the code becomes present in tfma.eval_saved_model, the tests will not pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants