Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove tests of deprecated operators and adapt to GitHub CI. #483

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

MoFHeka
Copy link
Collaborator

@MoFHeka MoFHeka commented Jan 3, 2025

Description

dynamic_partition and dynamic_stitch missing compile implementation of the bool data type in older TensorFlow version. Now is time to remove TFRA DE same-name op when TensorFlow supports those data type.

Also fix Github CI have been unsupport python3.7

Also fix demo movielens-1m-keras-with-horovod.py. Prefix code for input feature should be in the upper bit.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Profile tensorflow trace view see if there is additional data D-H-D transport.

@MoFHeka MoFHeka requested a review from rhdong as a code owner January 3, 2025 08:10
@MoFHeka MoFHeka requested a review from jq January 3, 2025 08:10
@MoFHeka MoFHeka changed the title [Fix] Remove tests of deprecated operators. [Fix] Remove tests of deprecated operators and adapt to GitHub CI. Jan 6, 2025
@rhdong rhdong merged commit c94b4ab into tensorflow:master Jan 6, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants