-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate icingaweb2 setup #4
base: development
Are you sure you want to change the base?
Automate icingaweb2 setup #4
Conversation
Thanks, I'll take a look at it. Diffs of this size are easier to digest… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'd just wait for you to act on your #TODO items, such as the i2_webui_user
.
I'd perhaps just use a regular variable for the api user password now and do the vault stuff in a separate diff/PR?
Also, we already have i2_api_users
on the masters (in my case, inside group_vars/masters/basic.yml
), shouldn't we try to re-use them?
Well, either that, or as you said, have the config here, but then automatically generate the api user. So that'd mean, e.g. before running the Master - Create Api-Users config file
task, merge this user into i2_api_users
?!
tasks/icinga2-web2.yml
Outdated
become: true | ||
template: | ||
src: "icingaweb2-config.ini.j2" | ||
dest: "/{{ item.dest }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your dest
below are already absolute.
Now, I might have used dest: "/etc/icingaweb2/{{ item.dest }}"
here, but I can also see the advantage of having the absolute path below. I'd still refactor this and move the common root up here.
the additional modules as well
Handle additional actions for director module
…all configuration directories
configuration generation
to upgrade the packages as well
handler so icinga2 will be restarted on upgrades
option (i2_bootstrap_cacheable) to cache the values. This will help with hosts which are temporarily down
…doesn't support https out of the box
As discussed the code to automate the icingaweb2 setup (Fixes #2)
This is still work in progress...
I introduced quite a lot of new variables and I am not really sure about the naming convention for those yet.
TODO: Also not all the _default and _custom variants are there yet
Also for Icingaweb you always? wan't an Icinga API user. So we maybe might just as well create that one in the default playbook when i2_setup_webui is set?
TODO: The OS user and group of the IcingaWeb configuration should have defaults based on the OS.
I am still figuring out how the other IcingaWeb2 modules need to be installed, probably I also will change some stuff there as well as we will be using the Director and GraphiteWeb modules