Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Result): Result.recoverWhen should execute the predicate before executing the lambda #8

Merged
merged 1 commit into from
Nov 12, 2019
Merged

fix(Result): Result.recoverWhen should execute the predicate before executing the lambda #8

merged 1 commit into from
Nov 12, 2019

Conversation

floriansimon1
Copy link
Collaborator

@floriansimon1 floriansimon1 commented Nov 11, 2019 •
edited
Loading

Fixes #7

@floriansimon1 floriansimon1 requested review from kwisatz and a user November 11, 2019 23:59
@floriansimon1 floriansimon1 force-pushed the bugfix/result-recover-when branch from 5fd4058 to 5d3ffa6 Compare November 12, 2019 00:00
@floriansimon1
Copy link
Collaborator Author

Note that I haven't done the release chores. Would you like to take care of them?

@kwisatz
Copy link
Member

kwisatz commented Nov 12, 2019

We'll take care of releasing your fuxes, don't worry 😉

@floriansimon1
Copy link
Collaborator Author

floriansimon1 commented Nov 12, 2019 •
edited
Loading

We'll take care of releasing your fuxes, don't worry 😉

Pun intended?

@floriansimon1 floriansimon1 merged commit 798c9b9 into master Nov 12, 2019
@floriansimon1 floriansimon1 deleted the bugfix/result-recover-when branch November 12, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwisatz kwisatz kwisatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order of predicate and lambda in recoverWhen
2 participants
@floriansimon1 @kwisatz