Use named type for object handler (#308)

Signed-off-by: Igor Shishkin <me@teran.ru>
teran · Jan 11, 2025 · f32ebbc · f32ebbc
1 parent 868e604
commit f32ebbc
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/cli/service/source/local/local.go b/cli/service/source/local/local.go
@@ -42,7 +42,7 @@ func New(dir string, c cache.CacheRepository) source.Source {
 	}
 }
 
-func (l *local) Process(ctx context.Context, handler func(ctx context.Context, obj source.Object) error) error {
+func (l *local) Process(ctx context.Context, handler source.ObjectHandler) error {
 	log.WithFields(log.Fields{
 		"source_type": sourceType,
 		"directory":   l.dir,

diff --git a/cli/service/source/mock/mock.go b/cli/service/source/mock/mock.go
@@ -17,7 +17,7 @@ func New() *Mock {
 	return &Mock{}
 }
 
-func (m *Mock) Process(ctx context.Context, handler func(ctx context.Context, obj source.Object) error) error {
+func (m *Mock) Process(ctx context.Context, handler source.ObjectHandler) error {
 	args := m.Called()
 	return args.Error(0)
 }
diff --git a/cli/service/source/source.go b/cli/service/source/source.go
@@ -13,6 +13,8 @@ type Object struct {
 	MimeType string
 }
 
+type ObjectHandler func(ctx context.Context, obj Object) error
+
 type Source interface {
-	Process(ctx context.Context, handler func(ctx context.Context, obj Object) error) error
+	Process(ctx context.Context, handler ObjectHandler) error
 }
diff --git a/cli/service/source/yum/yum.go b/cli/service/source/yum/yum.go
@@ -51,7 +51,7 @@ func New(repoURL string, rpmGPGKeyURL, rpmGPGKeySHA256 *string) source.Source {
 	}
 }
 
-func (r *repository) Process(ctx context.Context, handler func(ctx context.Context, obj source.Object) error) error {
+func (r *repository) Process(ctx context.Context, handler source.ObjectHandler) error {
 	log.WithFields(log.Fields{
 		"repository_url": r.repoURL,
 	}).Info("running creating version from YUM repository ...")