WIP: Add TypeScript definitions #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome - Let me know when this is ready for merge 👍 Should the types be in DefinitelyTyped or here? @lukeed – what do you do usually do? |
|
I keep them in the module when they don't rely on a dependency tree of other types |
terkelg
reviewed
Aug 17, 2019
| @@ -21,7 +22,8 @@ | |||
| "prepublish": "npm run build" | |||
| }, | |||
| "files": [ | |||
| "dist" | |||
| "dist", | |||
| "types" | |||
There was a problem hiding this comment.
Can we do "*.d.ts", and place the types in the root of the project as sqliterally.d.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge!
Not yet tested.