-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Enable acceleration support, raies MSV or Terraform and AWS provider #99
Merged
bryantbiggs
merged 9 commits into
terraform-aws-modules:master
from
james-martinez:feat-enable_acceleration
Dec 20, 2024
Merged
feat!: Enable acceleration support, raies MSV or Terraform and AWS provider #99
bryantbiggs
merged 9 commits into
terraform-aws-modules:master
from
james-martinez:feat-enable_acceleration
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-martinez
changed the title
Draft: add enable_acceleration support
Draft: feat: enable_acceleration support
Aug 14, 2024
james-martinez
changed the title
Draft: feat: enable_acceleration support
feat: enable_acceleration support
Aug 14, 2024
james-martinez
changed the title
feat: enable_acceleration support
feat: Enable acceleration support
Aug 14, 2024
Please fix the failing CI runs (and docs). |
Can someone test the example? I don't have an aws account to deploy the example. Thanks |
I have also confirmed the |
bryantbiggs
reviewed
Oct 11, 2024
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Is there anything else needed for this to be reviewed and merged? Having acceleration support would be great. |
bryantbiggs
changed the title
feat: Enable acceleration support
feat!: Enable acceleration support, raies MSV or Terraform and AWS provider
Dec 20, 2024
bryantbiggs
approved these changes
Dec 20, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Dec 20, 2024
## [4.0.0](v3.7.2...v4.0.0) (2024-12-20) ### ⚠ BREAKING CHANGES * Enable acceleration support, raies MSV or Terraform and AWS provider (#99) ### Features * Enable acceleration support, raies MSV or Terraform and AWS provider ([#99](#99)) ([4f7c4d2](4f7c4d2)) ### Bug Fixes * Update CI workflow versions to latest ([#100](#100)) ([139920a](139920a))
This PR is included in version 4.0.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added bool var for acceleration support.
Added terraform parameter in each vpn resource to reference the var.
An accelerated Site-to-Site VPN connection (accelerated VPN connection) uses AWS Global Accelerator to route traffic from your on-premises network to an AWS edge location that is closest to your customer gateway device. AWS Global Accelerator optimizes the network path, using the congestion-free AWS global network to route traffic to the endpoint that provides the best application performance (for more information, see AWS Global Accelerator).
Motivation and Context
https://docs.aws.amazon.com/vpn/latest/s2svpn/accelerated-vpn.html
Resolves #98
Breaking Changes
No breaking changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request