Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Enable acceleration support, raies MSV or Terraform and AWS provider #99

Conversation

james-martinez
Copy link
Contributor

@james-martinez james-martinez commented Aug 14, 2024

Description

Added bool var for acceleration support.
Added terraform parameter in each vpn resource to reference the var.

An accelerated Site-to-Site VPN connection (accelerated VPN connection) uses AWS Global Accelerator to route traffic from your on-premises network to an AWS edge location that is closest to your customer gateway device. AWS Global Accelerator optimizes the network path, using the congestion-free AWS global network to route traffic to the endpoint that provides the best application performance (for more information, see AWS Global Accelerator).

Motivation and Context

https://docs.aws.amazon.com/vpn/latest/s2svpn/accelerated-vpn.html

Resolves #98

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@james-martinez james-martinez changed the title Draft: add enable_acceleration support Draft: feat: enable_acceleration support Aug 14, 2024
@james-martinez james-martinez changed the title Draft: feat: enable_acceleration support feat: enable_acceleration support Aug 14, 2024
@james-martinez james-martinez changed the title feat: enable_acceleration support feat: Enable acceleration support Aug 14, 2024
@antonbabenko
Copy link
Member

Please fix the failing CI runs (and docs).

@james-martinez james-martinez marked this pull request as draft August 15, 2024 11:53
@james-martinez james-martinez marked this pull request as ready for review August 15, 2024 12:44
@james-martinez
Copy link
Contributor Author

Can someone test the example? I don't have an aws account to deploy the example.

Thanks

@dmildh-absci
Copy link

I have also confirmed thevpn_connection_enable_acceleration = true option is working if someone can merge this.

variables.tf Outdated Show resolved Hide resolved
james-martinez and others added 2 commits October 11, 2024 15:50
@shmick
Copy link

shmick commented Dec 20, 2024

Is there anything else needed for this to be reviewed and merged? Having acceleration support would be great.

@bryantbiggs bryantbiggs changed the title feat: Enable acceleration support feat!: Enable acceleration support, raies MSV or Terraform and AWS provider Dec 20, 2024
@bryantbiggs bryantbiggs merged commit 4f7c4d2 into terraform-aws-modules:master Dec 20, 2024
11 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 20, 2024
## [4.0.0](v3.7.2...v4.0.0) (2024-12-20)

### ⚠ BREAKING CHANGES

* Enable acceleration support, raies MSV or Terraform and AWS provider (#99)

### Features

* Enable acceleration support, raies MSV or Terraform and AWS provider ([#99](#99)) ([4f7c4d2](4f7c4d2))

### Bug Fixes

* Update CI workflow versions to latest ([#100](#100)) ([139920a](139920a))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.0 🎉

@james-martinez james-martinez deleted the feat-enable_acceleration branch December 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable acceleration flag when use TGW
5 participants