Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VERSION to test CI #3481

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Conversation

jlestel
Copy link
Contributor

@jlestel jlestel commented Nov 22, 2023

Test PR to demonstrate how CI build images (hosted on GHCR) from PR sources.

@jlestel jlestel changed the title Update VERSION to test CI WIP: Update VERSION to test CI Nov 22, 2023
@JakobLichterfeld
Copy link
Collaborator

I think about releasing new version the next days. Would go with 1.28.0 to show the first release of teslamate-org.

@JakobLichterfeld JakobLichterfeld added the WIP Work in progress label Nov 22, 2023
@jlestel
Copy link
Contributor Author

jlestel commented Nov 22, 2023

I think about releasing new version the next days. Would go with 1.28.0 to show the first release of teslamate-org.

It was just a test PR to trigger the CI :) the result seems correct.

To finalize, we need to make the packages https://github.com/teslamate/teslamate/pkgs/container/teslamate and https://github.com/teslamate/teslamate/pkgs/container/teslamate%2Fgrafana public

@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Nov 22, 2023

It was just a test PR to trigger the CI :) the result seems correct.

I know, just wanna give you a heads up :-)

Why is the digest size 0 byte?

Edit: I do not have access to the pkgs

@jlestel
Copy link
Contributor Author

jlestel commented Nov 22, 2023

@JakobLichterfeld in order not to trigger the CI on each PR, do you want to condition its launch on the presence of a particular label?

@jlestel
Copy link
Contributor Author

jlestel commented Nov 22, 2023

Why is the digest size 0 byte?

I guess it's because it only contains 3 empty files. an approximation of GH, that's 643 bytes in reality

@DrMichael
Copy link
Collaborator

I think about releasing new version the next days. Would go with 1.28.0 to show the first release of teslamate-org.

That wouls be 'latest', right? What about 'edge'? When and how often is that being updated?

@jlestel
Copy link
Contributor Author

jlestel commented Nov 22, 2023

Edit: I do not have access to the pkgs

@adriankumpf @DrMichael could you make packages public? I want to give access to the intermediate build to facilitate the testing of certain PRs.

The 2 packages:

@jlestel
Copy link
Contributor Author

jlestel commented Nov 22, 2023

I think about releasing new version the next days. Would go with 1.28.0 to show the first release of teslamate-org.

That wouls be 'latest', right? What about 'edge'? When and how often is that being updated?

  • Edge is released each sunday at 03:00 AM and based on master
  • Latest is released with a version (v*..)

@DrMichael
Copy link
Collaborator

@adriankumpf @DrMichael could you make packages public? I want to give access to the intermediate build to facilitate the testing of certain PRs.

The 2 packages:

I get a 404 with those links...

@jlestel
Copy link
Contributor Author

jlestel commented Nov 22, 2023

I get a 404 with those links...

You don't have access because it's not public yet. I think only Adrian can give us access to it :)

@DrMichael
Copy link
Collaborator

Hmmm, are you sure about the links? I can see the following:

https://github.com/orgs/teslamate-org/packages/container/package/teslamate
https://github.com/orgs/teslamate-org/packages/container/package/teslamate%2Fgrafana

The teslamate folder has this contents:
image

@JakobLichterfeld
Copy link
Collaborator

in order not to trigger the CI on each PR, do you want to condition its launch on the presence of a particular label?

For now, we can go with all PR without .github (as we do right now) imo, since tagging is a manual process. We can exclude doc changes, but I would stick with all for now.

@jlestel
Copy link
Contributor Author

jlestel commented Nov 22, 2023

https://github.com/orgs/teslamate-org/packages/container/package/teslamate
https://github.com/orgs/teslamate-org/packages/container/package/teslamate%2Fgrafana

Sorry, this is the good links. 404 for me because not public.

@JakobLichterfeld
Copy link
Collaborator

Yeah, these links are working, I could not change permissions, perhaps @DrMichael can

@DrMichael
Copy link
Collaborator

Sorry, no. @adriankumpf has to do that.
image

@jlestel
Copy link
Contributor Author

jlestel commented Nov 24, 2023

Sorry, no. @adriankumpf has to do that. image

@DrMichael do you have a way to contact @adriankumpf about this?

@DrMichael
Copy link
Collaborator

No, only this way. Sorry.
@adriankumpf It might be good to make @JakobLichterfeld and/or @jlestel admin of teslamate-org.

@adriankumpf
Copy link
Collaborator

@DrMichael I have changed an org setting that I believe should allow members to make packages public. Both packages are now also public

@JakobLichterfeld JakobLichterfeld merged commit 5ffbe9d into teslamate-org:ci Nov 25, 2023
5 checks passed
@JakobLichterfeld JakobLichterfeld added github_actions Pull requests that update Github_actions code and removed WIP Work in progress labels Nov 25, 2023
@JakobLichterfeld JakobLichterfeld changed the title WIP: Update VERSION to test CI Update VERSION to test CI Nov 25, 2023
@DrMichael
Copy link
Collaborator

  • Edge is released each sunday at 03:00 AM and based on master

Are you sure. At least the Charges dashboard in edge is still the old one. In latest, it is the new one.

@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Nov 26, 2023

Schedule for edge:

- cron: "0 3 * * 0"

latest is the latest released version

@DrMichael
Copy link
Collaborator

DrMichael commented Nov 26, 2023

Hmmm, strange. Removed both image and volume. Pulled fresh grafana:edge...
Still in Charges the rightmost column is Driven with edge, Odometer with latest. Grafana version shows v9.5.10.

Anythng else I could clear?

master in https://github.com/teslamate-org/teslamate/pkgs/container/teslamate%2Fgrafana is uptodate. Could it be, that the image did not make it to the docker hub?

JakobLichterfeld added a commit that referenced this pull request Nov 27, 2023
* ci: workflow run on ci branch for debuging

* Run CI with PR sources (#3479)

* Run CI with PR sources

* Add CI branch to the pull_request_target

---------

Co-authored-by: Julien <julien@citio.digital>

* GHCR Purge success even if package doesn't exist (#3480)

* GHCR Purge success even if package doesn't exist

* Add CI branch to pull_request_target

* typo

---------

Co-authored-by: Julien <julien@citio.digital>

* Update VERSION to test CI (#3481)

---------

Co-authored-by: jlestel <jlestel@gmail.com>
Co-authored-by: Julien <julien@citio.digital>
JakobLichterfeld added a commit that referenced this pull request Feb 9, 2024
* ci: workflow run on ci branch for debuging

* Run CI with PR sources (#3479)

* Run CI with PR sources

* Add CI branch to the pull_request_target

---------

Co-authored-by: Julien <julien@citio.digital>

* GHCR Purge success even if package doesn't exist (#3480)

* GHCR Purge success even if package doesn't exist

* Add CI branch to pull_request_target

* typo

---------

Co-authored-by: Julien <julien@citio.digital>

* Update VERSION to test CI (#3481)

---------

Co-authored-by: jlestel <jlestel@gmail.com>
Co-authored-by: Julien <julien@citio.digital>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants