Bo ce filter list #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0aa76d9): https://tcl-71-smart-shopping-list--pr22-bo-ce-filter-list-km16z2qf.web.app (expires Tue, 27 Feb 2024 10:10:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e7ade9d0f374c4ddb5d7ab6fc541062fc7a1ab4 |
BikeMouse
approved these changes
Feb 19, 2024
elitcenk
reviewed
Feb 20, 2024
src/components/SearchList.jsx
Outdated
| const SearchList = ({ data, setNewList }) => { | ||
| const [value, setValue] = useState(''); | ||
|
|
||
| const handlefiltering = (e) => { |
There was a problem hiding this comment.
It can renamed with handleFiltering
elitcenk
reviewed
Feb 20, 2024
src/components/SearchList.jsx
Outdated
| const [value, setValue] = useState(''); | ||
|
|
||
| const handlefiltering = (e) => { | ||
| const userinput = e.target.value.toLowerCase(); |
There was a problem hiding this comment.
Variable names updated!
vivitt
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Nice job! The new feature works perfectly and meets all the requirements ✨
As a suggestion, I wonder if it wouldn't be clearer if the name of SearchList were something like SearchForm (given that it is a form similar to the ListForm we created in the previous issue with Celine).
elitcenk
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new component,
SearchList.jsx, which can be used to filter theListview based on current input. The filtering is used to display only items which include the current input's value. The component also includes abuttonto clear the input field.For this issue we had to deepen our understanding of React's component lifecycle and the way the
useStatehook updates its values. This came to be while having to update the list being displayed dynamically and its initial loading.Related Issue
Closes #7
Acceptance Criteria
Listview, above the shopping list<label>!) which narrows down the list as the user typesType of Changes
Updates
Before
After
Testing Steps / QA Criteria
git pull origin bo_ce_filter_listnpm start