-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerts in-app #74
Alerts in-app #74
Conversation
…ng items or sharing a list
Visit the preview URL for this PR (updated for commit 09c1a64): https://tcl-71-smart-shopping-list--pr74-alert-messages-hjj39zxe.web.app (expires Thu, 11 Apr 2024 09:35:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e7ade9d0f374c4ddb5d7ab6fc541062fc7a1ab4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Borja, the changes look nice!
The only thing I would suggest is to add a fixed height to the section elements (I tested with h-60
and seemed to work fine) in ManageList.jsx, to avoid the layout shifting when showing/not showing messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is so much better!
Hey @vivitt! I played with it a bit and arrived at something that prevents layout shift (most of the time, if the item name is too long it will cause the element to take up multiple lines, so that's an edge case) while not creating too much blank space. Tell me what you think if you check it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this update!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
This PR displays alert messages from adding items or sharing a list in-app, instead of with the browser's native alert() function.
Related Issue
closes #73
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
git pull
git checkout alert-messages