-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Warren Chan to Contributors #22
Conversation
Visit the preview URL for this PR (updated for commit 4b8bb3a): https://tcl-75-smart-shopping-list--pr22-adding-warren-to-con-um2ksetk.web.app (expires Mon, 19 Aug 2024 19:49:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde |
CONTRIBUTORS.md
Outdated
@@ -7,6 +7,7 @@ Add yourself as a contributor to this project as a Markdown link that links your | |||
## Cohort Participants | |||
|
|||
Gabrielle Lommel (https://github.com/granolagabrielle) :seedling: | |||
Warren Chan (https://github.com/warrenchan13) 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @warrenchan13! Almost there! Let's use the same syntax in the example above to get the markdown formatting:
name emoji
Could you also update @granolagabrielle entry? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated mine and @granolagabrielle's entry
- [Gabrielle Lommel](https://github.com/granolagabrielle) :seedling: | ||
- [Warren Chan](https://github.com/warrenchan13) 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! And thanks for updating the existing entry! 🚀
For an example of how to fill this template out, see this Pull Request.
Description
In this PR, Warren is added to CONTRIBUTORS.md
Related Issue
Acceptance Criteria
Warren is in the file with the link to the GitHub repo + favorite emoji
Type of Changes
enhancement
Updates
Before
Warren was not in the CONTRIBUTORS file.
After
Warren is in the CONTRIBUTORS file.
Testing Steps / QA Criteria
Verify that Warren appears in the CONTRIBUTORS file.