Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added name to Contributors.md file #23

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Added name to Contributors.md file #23

merged 2 commits into from
Aug 21, 2024

Conversation

dilekbaykara
Copy link
Collaborator

@dilekbaykara dilekbaykara commented Aug 13, 2024

For an example of how to fill this template out, see this Pull Request.

Description

Added name to Contributors.md file

Related Issue

Acceptance Criteria

Name, link, and emoji

Type of Changes

Added emoji, name, and GitHub link to list of contributors

Updates

Before

After

Testing Steps / QA Criteria

Copy link

github-actions bot commented Aug 13, 2024

Visit the preview URL for this PR (updated for commit d111770):

https://tcl-75-smart-shopping-list--pr23-new-feature-haya9af3.web.app

(expires Tue, 27 Aug 2024 17:53:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde

@deeheber
Copy link
Member

Pre-emptively approving so you aren't waiting for me.

In order to merge this into the main branch you will need to resolve the merge conflicts first. Once resolved, feel free to hit the "merge pull request" button.

Video demo here: https://the-collab-lab.slack.com/archives/C07FS2SLVEJ/p1723656888946809?thread_ts=1723548237.006659&cid=C07FS2SLVEJ

Copy link
Collaborator

@ahsanatzapier ahsanatzapier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling the merge conflict! 🚀

Copy link
Collaborator

@jendevelops jendevelops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dilekbaykara dilekbaykara merged commit a06766c into main Aug 21, 2024
2 checks passed
@dilekbaykara dilekbaykara deleted the new-feature branch August 21, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants