Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing props for issue 9 #42

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

granolagabrielle
Copy link
Collaborator

Description

Two of the props in List.jsx went missing in my merge conflict. I added them back in and the new feature now works correctly again.

Type of Changes

bug fix

Testing Steps / QA Criteria

  • Check the box next to an item to mark it as purchased
  • Refresh the page to make sure the box is still checked
  • Check the item in firebase to ensure that the dateLastPurchased and totalPurchases were updated correctly

Copy link

github-actions bot commented Sep 9, 2024

Visit the preview URL for this PR (updated for commit 282295c):

https://tcl-75-smart-shopping-list--pr42-gb-mark-purchased-fi-e73k86xg.web.app

(expires Mon, 16 Sep 2024 22:25:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde

Copy link
Member

@deeheber deeheber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to merge to me. Confirmed it met all of the acceptance criteria by testing on the deployed version of this branch.

Thanks for these changes.

@granolagabrielle granolagabrielle merged commit eb4fced into main Sep 10, 2024
3 checks passed
@granolagabrielle granolagabrielle deleted the gb-mark-purchased-fixes branch September 10, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants