merged useEffects and changed clear button

the-collab-lab · Aug 31, 2024 · 09f2d77 · 09f2d77
1 parent b8dc409
commit 09f2d77
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/views/List.jsx b/src/views/List.jsx
@@ -10,17 +10,13 @@ export function List({ data }) {
 		setFilterVal('');
 	};
 
-	useEffect(() => {
-		setFilteredList(data);
-	}, [data]);
-
 	useEffect(() => {
 		setFilteredList(
 			data.filter((item) =>
 				item.name.toLowerCase().includes(filterVal.toLowerCase()),
 			),
 		);
-	}, [filterVal]);
+	}, [filterVal, data]);
 
 	return (
 		<>
@@ -37,7 +33,7 @@ export function List({ data }) {
 					value={filterVal}
 					onChange={(e) => setFilterVal(e.target.value)}
 				/>
-				<button>Clear</button>
+				{filterVal && <button>Clear</button>}
 			</form>
 
 			<ul>