Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional sign in and sign out button #17

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

mentalcaries
Copy link
Collaborator

@mentalcaries mentalcaries commented Aug 11, 2024

Description

For this PR we:

  • imported useAuth and the components for the sign in and sign out buttons

Related Issue

closes #1

Acceptance Criteria

  • The useAuth hook as well as the SignInButton and SignOutButton components are imported into Layout.jsx.
  • The SignInButton is displayed on every page if the user is not signed in.
  • The SignOutButton is displayed on every page if the user is signed in.

Type of Changes

Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g., bug fix or enhancement are common ones.

Updates

Before

image

After

Screenshot 2024-08-11 at 8 35 17 AM Screenshot 2024-08-11 at 8 35 09 AM

Testing Steps / QA Criteria

@mentalcaries mentalcaries added the enhancement New feature or request label Aug 11, 2024
Copy link

Visit the preview URL for this PR (updated for commit a54aecf):

https://tcl-76-smart-shopping-list--pr17-mz-dj-add-auth-25hk6wr6.web.app

(expires Sun, 18 Aug 2024 15:37:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 512b1a88be8ae05fd3e727b99332819df760271d

@mentalcaries mentalcaries marked this pull request as ready for review August 11, 2024 15:37
Copy link
Collaborator

@nathanejbrown nathanejbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nathanejbrown nathanejbrown merged commit 8a02fe9 into main Aug 11, 2024
3 checks passed
@nathanejbrown nathanejbrown deleted the mz-dj-add-auth branch August 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1. As a user, I want to be able to sign in to the app.
3 participants