-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SL-253] Update seating availability calculation depending on seat reservation. #3461
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An optional really small code change, otherwise fine.
src/Tribe/Ticket_Object.php
Outdated
* @since TBD | ||
* | ||
* @param int $stock The stock level of the ticket. | ||
* @param Tribe__Tickets__Ticket_Object $ticket The ticket object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alias this to Ticket_Object
and improve the code readability.
Co-authored-by: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
…3-et-removing-screen-options
…ving-screen-options [ET-2273] Fix show screen options filter in ET
if ( ! isset( $capacity_by_type[ $seat_type ] ) ) { | ||
$capacity_by_type[ $seat_type ] = $capacity; | ||
} | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these tabs.
$capacity = $ticket->capacity(); | ||
$stock = $ticket->stock(); | ||
$sold_qty = $ticket->qty_sold(); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these tabs.
…e-hook-update Prevent aggressive hook update
…-keys-default-array
…isable-foreign-keys-default-array ET-2275 Add Default Empty Array to Foreign Key Check
🎫 Ticket
SL-253
🗒️ Description
🎥 Artifacts
🎥 screencast(s): https://share.cleanshot.com/59KQgGdS
✔️ Checklist
npm run changelog
to add changelog file(s). More info herewpunit
orintegration
tests.wpunit
orintegration
tests.