Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved filter to closure to avoid loading issues #3466

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Moved filter to closure to avoid loading issues #3466

merged 4 commits into from
Jan 8, 2025

Conversation

rafsuntaskin
Copy link
Contributor

@rafsuntaskin rafsuntaskin commented Dec 20, 2024 •
edited
Loading

🎫 Ticket

[TICKET_ID]
ZD: https://ithemeshelp.zendesk.com/agent/tickets/673799

🗒️ Description

🎥 Artifacts

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@rafsuntaskin rafsuntaskin added the needs release Needs an associated release in Jira before merging. label Dec 20, 2024
@rafsuntaskin rafsuntaskin self-assigned this Dec 20, 2024
dpanta94
dpanta94 requested changes Dec 20, 2024
View reviewed changes
Copy link
Member

@dpanta94 dpanta94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase against IMP, add changelog and lets make sure all the tests are passing please :D

@rafsuntaskin rafsuntaskin changed the base branch from master to release/T25.imp January 7, 2025 20:37
@rafsuntaskin rafsuntaskin marked this pull request as ready for review January 8, 2025 10:31
@rafsuntaskin rafsuntaskin requested a review from dpanta94 January 8, 2025 11:01
@rafsuntaskin rafsuntaskin added merge Status: ready to merge. and removed needs release Needs an associated release in Jira before merging. labels Jan 8, 2025
@rafsuntaskin rafsuntaskin merged commit 8acdf91 into release/T25.imp Jan 8, 2025
20 of 22 checks passed
@rafsuntaskin rafsuntaskin deleted the fix/resolve-resend-fatal branch January 8, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpanta94 dpanta94 dpanta94 approved these changes

@Camwyn Camwyn Camwyn approved these changes

Assignees

@rafsuntaskin rafsuntaskin

Labels
merge Status: ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafsuntaskin @Camwyn @dpanta94