Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ET-2279] Fix - Stripe webhooks generating duplicate attendees. #3469

Merged
merged 4 commits into from
Jan 6, 2025
Merged

[ET-2279] Fix - Stripe webhooks generating duplicate attendees. #3469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d2c8d7
fix attendee duplication by reverting payment intent update changes
rafsuntaskin Jan 5, 2025
a8047bc
updated doc block
rafsuntaskin Jan 5, 2025
09ab1f9
Fix ft_smoketest dump
dpanta94 Jan 6, 2025
04661d1
changelog updated
rafsuntaskin Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fix-et-2279-stripe-duplicate-attendees
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: fix

Fixed duplication of attendees while using Stripe webhooks with TicketsCommerce. [ET-2279]
8 changes: 2 additions & 6 deletions src/Tickets/Commerce/Gateways/Stripe/Webhooks/Payment_Intent_Webhook.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ protected static function get_payment_intent_data( array $event ): array {
*
* @since 5.3.0
* @since 5.16.0 Remove deprecation notice.
* @since 5.18.0 Only check matching payment intent ids if they are not pending or action required.
* @since 5.18.0 Only check matching payment intent ids if they are not pending or action required.
* @since TBD Removed the check for the payment intent status for pending or action required.
*
* @param array $payment_intent_received The payment intent data received
* @param array[] $payment_intents_stored The payment intent data stored from each update, keyed by status.
Expand All @@ -135,11 +136,6 @@ public static function should_payment_intent_be_updated( $payment_intent_receive
}

foreach ( $payment_intents_stored as $status => $intents ) {
// Skip if the status is pending or action required.
if ( in_array( $status, [ Pending::SLUG, Action_Required::SLUG ], true ) ) {
continue;
}

foreach( $intents as $intent ) {
// This payment intent has already been processed and updated.
if ( $payment_intent_received['id'] === $intent['id'] ) {
Expand Down
Loading
Loading