Prevent duplicated orders and attendees as a result #3470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redscar
reviewed
Jan 6, 2025
stratease
requested changes
Jan 6, 2025
lucatume
requested changes
Jan 6, 2025
Camwyn
reviewed
Jan 6, 2025
Camwyn
requested changes
Jan 7, 2025
Comment on lines
+475
to
+484
| if ( ! empty( $args['email'] ) ) { | ||
| $update_args['email'] = $args['email']; | ||
| } | ||
|
|
||
| if ( | ||
| empty( $args['email'] ) | ||
| && ! empty( $order->purchaser['email'] ) | ||
| ) { | ||
| $update_args['email'] = $order->purchaser['email']; | ||
| } |
There was a problem hiding this comment.
Should this be an elseif?
i.e.
if ( ! empty( $args['email'] ) ) { ... }
if ( empty( $args['email'] ) && ...
There was a problem hiding this comment.
root question - do we want to do both in order, or just one?
Comment on lines
+486
to
+494
| if ( ! empty( $args['full_name'] ) ) { | ||
| $update_args['full_name'] = $args['full_name']; | ||
| $update_args['title'] = $args['full_name']; | ||
| } | ||
|
|
||
| if ( | ||
| empty( $args['full_name'] ) | ||
| && ! empty( $order->purchaser['full_name'] ) | ||
| ) { |
Comment on lines
+131
to
+132
| } | ||
| $existing[] = $attendee_id; |
There was a problem hiding this comment.
Suggested change
| } | |
| $existing[] = $attendee_id; | |
| } | |
| $existing[] = $attendee_id; |
Comment on lines
+550
to
+553
| $gateway_key = $gateway::get_key(); | ||
|
|
||
| $existing_order_id = (int) $args['id'] ?? 0; | ||
| unset( $args['id'] ); |
There was a problem hiding this comment.
Suggested change
| $gateway_key = $gateway::get_key(); | |
| $existing_order_id = (int) $args['id'] ?? 0; | |
| unset( $args['id'] ); | |
| $gateway_key = $gateway::get_key(); | |
| $existing_order_id = (int) $args['id'] ?? 0; | |
| unset( $args['id'] ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ET-2279
🗒️ Description
Description in video: https://www.loom.com/share/43b3d371066c40a2b4c341e63044c8aa
🎥 Artifacts
Solution in video: https://www.loom.com/share/9342174d6cee48efaf7a4d3bec06abff
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.