Fix/duplicated orders and attendees #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpanta94
force-pushed
the
fix/duplicated-orders-and-attendees
branch
from
66992b5 to
9976f0e
Compare
dpanta94
requested review from
lucatume and
Camwyn
and removed request for
Camwyn
dpanta94
added
code review
8 tasks
dpanta94
commented
Jan 9, 2025
Co-authored-by: Stephen Page <stephen@theeventscalendar.com>
Co-authored-by: Stephen Page <stephen@theeventscalendar.com>
Camwyn
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ET-2280
ET-2282
🗒️ Description
The issues we have identified regarding attendee duplications are:
Issue 1: Duplicating attendees on status transition without considering if attendees are already created.
Issue 2: Duplicating orders and as a result attendees when at least one failed payment try.
Issue 3: Duplicating attendees because of race condition. Webhook running prior Ajax.
This PR is dealing with Issue 1 and 2.
Description in video: https://www.loom.com/share/43b3d371066c40a2b4c341e63044c8aa
🎥 Artifacts
Solution in video: https://www.loom.com/share/9342174d6cee48efaf7a4d3bec06abff
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.