BTRIA-2100/missing timezone parameter #2007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camwyn
added
the
needs release
Camwyn
removed
hold
tec-bot
reviewed
Dec 7, 2023
tec-bot
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
phpcs
src/functions/template-tags/date.php|360 col 1| Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed
src/functions/template-tags/date.php|360 col 8| Squiz.Commenting.FunctionComment.ParamCommentFullStop
Parameter comment must end with a full stop
src/functions/template-tags/date.php|360 col 15| Generic.Files.LineLength.MaxExceeded
Line exceeds maximum limit of 100 characters; contains 122 characters
tec-bot
reviewed
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTRIA-2100
The
$timezoneparameter seems to be missing fromtribe_get_end_date. As a result, the method returns UTC time zone.I added the missing parameter based on how it's done for
tribe_get_start_date.