Update wp-browser to v3.5 #2064
Conversation
| @@ -16,7 +16,7 @@ | |||
| * @package TEC\Common\Integration | |||
| */ | |||
| class Integration_AbstractTests { | |||
| public static function setUpBeforeClass() { | |||
| public static function setUpBeforeClass(): void { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
Method name "setUpBeforeClass" in class Integration_AbstractTests is not in snake case format, try "set_up_before_class"
| @@ -9,8 +9,7 @@ | |||
| use Tribe__Admin__Helpers as Admin_Helpers; | |||
|
|
|||
| class AdminHelpersTest extends \Codeception\TestCase\WPTestCase { | |||
|
|
|||
| function setUp() { | |||
| function setUp(): void { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Scope.MethodScope.Missing
Visibility must be declared on method "setUp"
| @@ -8,7 +8,7 @@ class Body_ClassesTest extends \Codeception\TestCase\WPTestCase { | |||
|
|
|||
| protected $class_object; | |||
|
|
|||
| function setUp() { | |||
| function setUp(): void { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Scope.MethodScope.Missing
Visibility must be declared on method "setUp"
| @@ -179,7 +179,7 @@ public function should_correctly_identify_new_posts() { | |||
| $this->assertFalse( $sut->is_new_post( array( $post_id, $second_post_id ) ) ); | |||
| } | |||
|
|
|||
| function setUp() { | |||
| function setUp(): void { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Scope.MethodScope.Missing
Visibility must be declared on method "setUp"
| @@ -14,7 +14,7 @@ class Classic_EditorTest extends \Codeception\TestCase\WPTestCase { | |||
| * | |||
| * @since 4.15.1 | |||
| */ | |||
| function setUp() { | |||
| function setUp(): void { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Scope.MethodScope.Missing
Visibility must be declared on method "setUp"
| // before | ||
| parent::setUp(); | ||
|
|
||
| // your set up methods here | ||
| Post_Root_Pool::reset_pool(); | ||
| } | ||
|
|
||
| public function tearDown() { | ||
| public function tearDown(): void { |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.CodeAnalysis.UselessOverridingMethod.Found
Possible useless method overriding detected
| @@ -3,14 +3,14 @@ | |||
|
|
|||
| class dateTest extends \Codeception\TestCase\WPTestCase { | |||
|
|
|||
| public function setUp() { | |||
| public function setUp(): void { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.CodeAnalysis.UselessOverridingMethod.Found
Possible useless method overriding detected
| // before | ||
| parent::setUp(); | ||
|
|
||
| // your set up methods here | ||
| } | ||
|
|
||
| public function tearDown() { | ||
| public function tearDown(): void { |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.CodeAnalysis.UselessOverridingMethod.Found
Possible useless method overriding detected
| @@ -3,14 +3,14 @@ | |||
|
|
|||
| class generalTest extends \Codeception\TestCase\WPTestCase { | |||
|
|
|||
| public function setUp() { | |||
| public function setUp(): void { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.CodeAnalysis.UselessOverridingMethod.Found
Possible useless method overriding detected
| // before | ||
| parent::setUp(); | ||
|
|
||
| // your set up methods here | ||
| } | ||
|
|
||
| public function tearDown() { | ||
| public function tearDown(): void { |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.CodeAnalysis.UselessOverridingMethod.Found
Possible useless method overriding detected
lucatume
force-pushed
the
test/wp-browser-v35
branch
from
eab36c4 to
2f2e2ca
Compare
|
@Camwyn can we make sure this gets merged into |
Part of Innovation Day work.
This PR updates wp-browser to version
3.5and, along with it, Codeception to version4and PHPUnit to version9.6.I've updated the test suite configurations (not really required, but it slims them down) and update the tests to use the correct PHPUnit assertions as required.
There is an hefty number of changed files, but the changes pretty much live all in
testsand the test themselves have been updated, not changed in nature.Note: code style checks are running on the test code, and failing.