Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract for handling merge logic. #2128

Merged
merged 12 commits into from
Jul 1, 2024
Merged

Abstract for handling merge logic. #2128

merged 12 commits into from
Jul 1, 2024

Conversation

stratease
Copy link
Contributor

@stratease stratease commented Jun 28, 2024 •
edited by jira bot
Loading

🎫 Ticket

TEC-5110

🗒️ Description

Abstract for merge logic with notices and deactivation logic.

🎥 Artifacts

✔️ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@stratease stratease self-assigned this Jun 28, 2024
@stratease stratease requested a review from bordoni June 28, 2024 02:10
@stratease stratease added the code review Status: requires a code review. label Jun 28, 2024
@bordoni bordoni added the enhance Code could use some enhancements before merging. label Jul 1, 2024
@stratease stratease requested a review from bordoni July 1, 2024 16:06
@stratease stratease removed the enhance Code could use some enhancements before merging. label Jul 1, 2024
Camwyn
Camwyn previously requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Camwyn Camwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly suggestions, feel free to comment/argue

src/Common/Integrations/Plugin_Merge_Provider_Abstract.php Outdated Show resolved Hide resolved
src/Common/Integrations/Plugin_Merge_Provider_Abstract.php Show resolved Hide resolved
src/Common/Integrations/Plugin_Merge_Provider_Abstract.php Outdated Show resolved Hide resolved
@stratease stratease requested a review from Camwyn July 1, 2024 22:42
dpanta94
dpanta94 previously approved these changes Jul 1, 2024
View reviewed changes
@stratease stratease dismissed stale reviews from Camwyn and bordoni July 1, 2024 23:15

handled

@stratease stratease merged commit 09d1edd into bucket/plugin-consolidation Jul 1, 2024
11 of 16 checks passed
@stratease stratease deleted the tweak/TEC-5110-notices-split-messages branch July 1, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tec-bot tec-bot tec-bot left review comments

@dpanta94 dpanta94 dpanta94 approved these changes

@bordoni bordoni Awaiting requested review from bordoni

@Camwyn Camwyn Awaiting requested review from Camwyn

Assignees

@stratease stratease

Labels
code review Status: requires a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stratease @bordoni @Camwyn @dpanta94 @tec-bot