-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating tests for Tribe__PUE__Notices class. #2332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redscar
added
the
needs release
Needs an associated release in Central before merging.
label
Dec 20, 2024
dpanta94
requested changes
Dec 20, 2024
redscar
removed
the
needs release
Needs an associated release in Central before merging.
label
Jan 6, 2025
dpanta94
requested changes
Jan 8, 2025
Eliminated unnecessary blank lines in the `remove_dismissed_notices` method to improve code readability. No functionality was affected by this change.
dpanta94
previously requested changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some TBDs
Camwyn
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions...
…ith direct instantiations of `Tribe__PUE__Notices`. Additionally, updated tests to align with the new approach and removed unnecessary setup and teardown methods.
Camwyn
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ET-2277
🗒️ Description
The original data corruption issue was caused by the use of
array_merge_recursive
, which allowed deeply nested and duplicated structures to accumulate intribe_pue_key_notices
. This PR resolves the issue by switching towp_parse_args
, which ensures that data is merged cleanly without creating unnecessary nesting.Prevention of Corrupted Data:
Repair of Existing Corrupted Data:
Performance and Stability Enhancements:
tribe_pue_key_notices
option.🎥 Artifacts
✔️ Checklist
npm run changelog
to add changelog file(s). More info herewpunit
orintegration
tests.wpunit
orintegration
tests.