Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-1834] Added title attribute for the Phone SVG for accessibility #2337

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

[ECP-1834] Added title attribute for the Phone SVG for accessibility #2337

wants to merge 17 commits into from

Conversation

redscar
Copy link
Contributor

@redscar redscar commented Jan 3, 2025 •
edited by jira bot
Loading

🎫 Ticket

ECP-1834

🗒️ Description

🎥 Artifacts

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

Camwyn and others added 17 commits May 2, 2024 15:46
@Camwyn
Fix checks in test that pass a post ID.
cf93217 
`current_user_can( 'read', $post_id )` 'read' does not use a post ID.
changed to `current_user_can( 'read_post', $post_id )`
@stratease
Fix issues with ability to tab to the search box.
75fb3ac
@stratease
Removed tabindex for search and allow tabbing into the options.
4cb427d
@stratease
Tab focus will highlight now.
db841b8
@stratease
Test code - removed.
3635b53
@stratease
Minify the last commit.
c21b8cb
@stratease
Changelog entry.
f2443f1
@Camwyn
Merge pull request #2080 from the-events-calendar/fix/read-check
4d3f741 
Fix checks in test that pass a post ID.
@Camwyn
Merge branch 'master' into fix/FBAR-330-tabindex-search
a45306c
@Camwyn
Merge branch 'release/T25.imp' into fix/FBAR-330-tabindex-search
42597e4
@Camwyn
Address whitespace oddity
6d90154
@Camwyn
remove commented out code
68a6f8f
@stratease
Fix whitespace indent.
9d66e46
@Camwyn
Merge pull request #2335 from the-events-calendar/fix/FBAR-330-tabind…
3b6d19f 
…ex-search

Fix/fbar 330 tabindex search
@redscar
Added title attribute for the Phone SVG for accessibility. [ECP-1834]
cd15010
@redscar
Merge remote-tracking branch 'origin/release/T25.imp' into tweak/ECP-…
1098d93 
…1834
@redscar
Updated WordPress version to 6.5.
002b01c
@redscar redscar self-assigned this Jan 3, 2025
@redscar redscar changed the base branch from release/T25.imp to master January 10, 2025 19:49
@redscar redscar added the needs release Needs an associated release in Central before merging. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@redscar redscar

Labels
needs release Needs an associated release in Central before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redscar @Camwyn @stratease