-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider registration actions should fire once or not at all when provider is inactive #2338
Merged
dpanta94
merged 11 commits into
release/T25.antman
from
fix/container-registration-actions
Jan 23, 2025
Merged
Provider registration actions should fire once or not at all when provider is inactive #2338
dpanta94
merged 11 commits into
release/T25.antman
from
fix/container-registration-actions
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpanta94
force-pushed
the
fix/container-registration-actions
branch
from
January 8, 2025 16:24
b1267da
to
b455ba8
Compare
dpanta94
changed the title
Fix container registration actions to only fire once or not at all wh…
Provider registration actions should fire once or not at all when provider is inactive
Jan 8, 2025
dpanta94
force-pushed
the
fix/container-registration-actions
branch
from
January 21, 2025 17:13
843d227
to
bad3f74
Compare
dpanta94
added
code review
Status: requires a code review.
needs tests
Needs tests before merging.
labels
Jan 21, 2025
lucatume
reviewed
Jan 23, 2025
lucatume
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
TCMN-178
🗒️ Description
Container would always fire registration actions of controllers for every time they would register and even if they were inactive.
As a result the following scenario would result in a fatal:
In ET -> Deactivate the main seating controller using a filter or const making the is_active method return false.
In ETP -> The main seating controller registers on the registration action of the ET's main seating controller.
We would have a fatal because the ET's main seating controller registration action would fire even when the controller is inactive.
🎥 Artifacts
Very low level change - making tests passing a valid artifact.
✔️ Checklist
npm run changelog
to add changelog file(s). More info herewpunit
orintegration
tests.wpunit
orintegration
tests.