Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCMN-177 Correction to docblocks for where and all methods #2341

Open
wants to merge 2 commits into
base: release/T25.imp
Choose a base branch
from

Conversation

sdokus
Copy link
Contributor

@sdokus sdokus commented Jan 8, 2025

🎫 Ticket

TCMN-177

πŸ—’οΈ Description

A user reported that they were seeing errors in PHPStan when trying to use the ORM and in reviewing our doc blocks for some methods, it seems like some updates are needed to more accurately reflect what is returned (all) or how many arguments are accepted (where).

πŸŽ₯ Artifacts

βœ”οΈ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@sdokus sdokus added question Needs an answer to one or more questions before merging. code review Status: requires a code review. labels Jan 8, 2025
@sdokus sdokus self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review. question Needs an answer to one or more questions before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant