Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help Hub FF into Imp #2344

Merged
merged 59 commits into from
Jan 9, 2025
Merged

Help Hub FF into Imp #2344

merged 59 commits into from
Jan 9, 2025

Conversation

redscar
Copy link
Contributor

@redscar redscar commented Jan 9, 2025

Moving Help Hub FF back into Imp

redscar and others added 30 commits November 26, 2024 11:24
@redscar
Restructred Iframe to stop loading Frontend scripts/styles. Fixes tec…
113a186 
…tria-569 & tectria-570.
@redscar
Fixed the Help Header from being hidden by the setting styles.
1f3c12c
@redscar
FF Fixes for spreadsheet rows -
b3c6944 
#39
#41
@redscar
Moved body selector into const to be reused.
bf15b21 
Fixed issue with tribe_asset.
@redscar
Merge pull request #2299 from the-events-calendar/tweak/tectria-572_h…
6623882 
…elp_header_hidden

[Tectria-572] Help Hub - H1 hidden
@redscar
Merge pull request #2300 from the-events-calendar/tweak/Help_Hub-FF_S…
e5953f5 
…preadsheet

Help Hub FF Fixes for spreadsheet
@redscar
Moved queryselectors to const to cut down on queries.
e024e92
@redscar
Added ID, and switched to getElementById.
87215ea
@redscar
Added prefix.
15e534c
@redscar
Fixed issue where going from a free plugin to a valid license could c…
d3ecc6c 
…reate false positives due to the transients not clearing.
@redscar
Fixed issue where going from a free plugin to a valid license could c…
1c53d0a 
…reate false positives due to the transients not clearing.
@redscar
Merge pull request #2298 from the-events-calendar/tweak/tectria-569_i…
b21846e 
…frame_styles

[Tectria-570][Tectria-569] Help Hub Iframe restructuring
@redscar
Rewrote tests to use fixture/closure logic.
90da8f4
@redscar
Combined foreach checks.
1752041
@redscar
Only delete the transient if the key is not valid.
bc61111
@redscar
Added logic For Uplink monitoring.
8d55060
@redscar
Set self::IS_ANY_LICENSE_VALID_TRANSIENT_KEY to valid when valid is…
718e339 
… truthy.
@redscar
Using hook wp_loaded.
86439eb
@redscar
Implemented Uplink to also reset the transient when applicable.
23c039e
@redscar
Cleaning up code, uplink, valid license, with invalid pue plugin is…
5fab8b8 
… failing.
@redscar
All tests passing.
8990108
@redscar
PHPCS fixes.
19c4b20
@redscar
Bump Uplink to version 2.2.2
969a185
@redscar
Updated composer.lock.
daf7bbe
@redscar
Added @since.
b13840b
@redscar
Fixed .lock file.
1d82331
@redscar
Moved back towards using an action to monitor `IS_ANY_LICENSE_VALID_T…
27913f3 
…RANSIENT_KEY`
@redscar
Switched IS_ANY_LICENSE_VALID_TRANSIENT_KEY structure from a string…
f1bdada 
…, to an array to keep track of what plugins are valid/invalid. Using a bool instead to keep track.
@redscar
Updated tests to validate that the transient matches the expected plu…
1fcf10a 
…gins.
@redscar
Changed to make it work with the old transient.
69a0875
dpanta94 and others added 19 commits December 19, 2024 17:37
@dpanta94
Update wp core in CI
47e3cb4
@dpanta94
another try to update wp core to latest
6740a09
@dpanta94
specify latest version
64b23ba
@dpanta94
downgrade to 6.6.1
4471180
@dpanta94
Update dump for activation suite
37a1454
@dpanta94
Fix failing tests
ae9b244
@dpanta94
fix end2end suite
ab4cc99
@redscar
Simplified logic.
d92d1f5
@redscar
Additional logic to also update the any license valid transient when …
4cea177 
…we do the basic `is_key_valid` method.
@redscar
Created wrapper function for get_uplink_resource when the uplink `get…
9691ceb 
…_resource` doesn't exist or isn't setup yet.
@redscar
Update tests to pass properly.
97dc970
@redscar
Merge release/T25.imp into branch.
d141fa4
@redscar
Merge release/T25.imp into branch.
06403f5
@redscar
Merge pull request #2343 from the-events-calendar/tweak/merge_imp_int…
a3e701c 
…o_helphub_ff

merging Imp into Help Hub FF
@redscar
Merge branch 'bucket/Help_Hub-FF' into tweak/TEC-5332_transients
b748650
@redscar
Rollback changes to QueueTest.php
3bad27a
@redscar
Moved the admin_init method back to the bottom.
f496ff6
@redscar
Added changelog.
d64465a
@redscar
Merge pull request #2331 from the-events-calendar/tweak/TEC-5332_tran…
28237f7 
…sients

Help Hub - Transient issue when installing new plugin
@redscar redscar added the code review Status: requires a code review. label Jan 9, 2025
@redscar redscar self-assigned this Jan 9, 2025
Camwyn
Camwyn requested changes Jan 9, 2025
View reviewed changes
src/Common/Admin/Help_Hub/Hub.php Outdated Show resolved Hide resolved
src/Common/Admin/Help_Hub/Hub.php Outdated Show resolved Hide resolved
src/Tribe/PUE/Checker.php Outdated Show resolved Hide resolved
bordoni
bordoni previously approved these changes Jan 9, 2025
View reviewed changes
@redscar redscar mentioned this pull request Jan 9, 2025
Merged
@redscar redscar requested a review from Camwyn January 9, 2025 18:17
@redscar redscar merged commit 5fc31e3 into release/T25.imp Jan 9, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camwyn Camwyn Camwyn approved these changes

@bordoni bordoni bordoni left review comments

Assignees

@redscar redscar

Labels
code review Status: requires a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@redscar @bordoni @Camwyn @dpanta94