12522: Add constraint rejection messages to XLSForm export #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plastichotsprings
changed the title
cooperka
approved these changes
Jan 21, 2025
app/models/forms/export.rb
Outdated
| if constraint_message.present? | ||
| constraint_msg_to_push[locale_index] += constraint_message | ||
| # Add semicolon concatenator, unless at the end | ||
| constraint_msg_to_push[locale_index] += "; " unless c_index + 1 == q.constraints.length |
There was a problem hiding this comment.
this works perfectly fine, just sharing a helpful alternative: [1, 2, 3].join("; ")
app/models/forms/export.rb
Outdated
|
|
||
| constraint_msg_to_push.each do |message| | ||
| questions.row(row_index).push(message) | ||
| end |
There was a problem hiding this comment.
rather than having a separate each loop here, it may be possible to combine these:
[].push(1, 2, *[3, 4]) is equivalent to [].push(1, 2, 3, 4), with the * "splat" operator deconstructing the array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to the XLSForm export feature for constraint messages.
If there are multiple constraint rules for a particular question, the method combines all provided messages into one string (per locale/translation), separated by a semicolon, in order to match the XLSForm standard format.
This PR also slightly rearranges the column orders to put the constraint messages column beside the constraint column for better readability.