Add pure pursuit test #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=========================================
+ Coverage 77.15% 86.55% +9.4%
=========================================
Files 18 20 +2
Lines 1160 1369 +209
Branches 119 129 +10
=========================================
+ Hits 895 1185 +290
+ Misses 239 154 -85
- Partials 26 30 +4
Continue to review full report at Codecov.
|
auscompgeek
requested changes
Feb 14, 2019
auscompgeek
reviewed
Feb 15, 2019
auscompgeek
reviewed
Feb 16, 2019
| floats(min_value=0, max_value=5), | ||
| ) | ||
| def test_find_speed(distance_along_path, start_speed, end_speed): | ||
| PP = pp.PurePursuit(0.2, 0.25) |
There was a problem hiding this comment.
Is this conceptually a constant?
auscompgeek
reviewed
Feb 16, 2019
auscompgeek
reviewed
Feb 16, 2019
auscompgeek
reviewed
Feb 16, 2019
tests/test_pure_pursuit.py
Outdated
| pp.PurePursuit.last_robot_x = 0 | ||
| pp.PurePursuit.last_robot_y = 0 | ||
| robot_pos = (pos_x, 0) | ||
| waypoints = [pp.Segment(0, 0, 0, 0, 0), pp.Segment(10, 0, 0, 0, 10)] |
There was a problem hiding this comment.
Why construct this list when you're not really using it?
…ontrol for vision alignment
Vision latency improvements
Barker changes
Climb tuning
Means that robot will always move even if throttle is closed.
Cleanup and improvement of various functions
- Remove heights not being used - Use sparkmaxes for arm motor - Use victor spx for intake motor
Cargo cleanup and added functionality
|
oh no what have you done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.