Pin wpilib-controller version #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just updated the wpilib-controller package with changes from the upstream PR. We should update our code to use this at some point.
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 83.68% 83.68%
=======================================
Files 21 21
Lines 1606 1606
Branches 160 160
=======================================
Hits 1344 1344
Misses 220 220
Partials 42 42Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just updated the wpilib-controller package with changes from the
upstream PR. We should update our code to use this at some point.
Any subsequent builds will fail if either this isn't merged in,
or someone actually updates the code to use the new calculate method.