Skip to content

Commit

Permalink
Stop in the workflow run ID to gh run download (#3593)
Browse files Browse the repository at this point in the history
In 078bc30 I reintroduced a typo in the
variable because of a merge conflict, making it end up as an empty
string again. It happened to work because it was the last run (default
behavior) but there's no guarantee this is correct.

Fixes: 078bc30 ("Rely on gh run download to extract the artifacts (#3591)")
  • Loading branch information
ekohl authored Jan 17, 2025
1 parent 078bc30 commit 0aeea1c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ jobs:
- name: Create preview layout
run: |
gh run download '${{ github.event.worfklow_run.id }}' --name 'foreman-docs-web-master' --dir preview
gh run download '${{ github.event.worfklow_run.id }}' --name 'foreman-docs-html-${{ fromJSON(env.PR_DATA).branch_name }}' --dir 'preview/${{ fromJSON(env.PR_DATA).target_name }}'
gh run download '${{ github.event.workflow_run.id }}' --name 'foreman-docs-web-master' --dir preview
gh run download '${{ github.event.workflow_run.id }}' --name 'foreman-docs-html-${{ fromJSON(env.PR_DATA).branch_name }}' --dir 'preview/${{ fromJSON(env.PR_DATA).target_name }}'
env:
GH_TOKEN: ${{ github.token }}

- name: Create old base
run: gh run download '${{ github.event.worfklow_run.id }}' --name foreman-docs-html-base --dir old
run: gh run download '${{ github.event.workflow_run.id }}' --name foreman-docs-html-base --dir old
env:
GH_TOKEN: ${{ github.token }}

Expand Down

0 comments on commit 0aeea1c

Please sign in to comment.