Skip to content

Commit

Permalink
Correctly invoke gh run download (#3587)
Browse files Browse the repository at this point in the history
In 242dde2 I forgot to add $ to the
variable, so it was taking it literally. This is something I tried to
fix in 313e77e but didn't.

Fixes: 242dde2 ("Use gh run download in previews (#3579)")
Fixes: 313e77e ("Use multiple gh run download commands (#3584)")
  • Loading branch information
ekohl authored Jan 17, 2025
1 parent be81ba3 commit 71b5724
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@v4

- name: Download metadata artifact
run: gh run download {{ github.event.worfklow_run.id }} -n pr
run: gh run download '${{ github.event.worfklow_run.id }}' -n pr

- name: Unzip artifact
run: unzip pr.zip
Expand All @@ -36,7 +36,7 @@ jobs:
- uses: actions/checkout@v4

- name: Download metadata artifact
run: gh run download {{ github.event.worfklow_run.id }} -n pr
run: gh run download '${{ github.event.worfklow_run.id }}' -n pr

- name: Unzip artifact
run: unzip pr.zip
Expand All @@ -45,10 +45,7 @@ jobs:
run: echo "PR_DATA=$(cat ./pr.json)" >> $GITHUB_ENV

- name: Download other artifacts
run: |
gh run download {{ github.event.worfklow_run.id }} -n 'foreman-docs-html-${{ fromJSON(env.PR_DATA).branch_name }}'
gh run download {{ github.event.worfklow_run.id }} -n foreman-docs-html-base
gh run download {{ github.event.worfklow_run.id }} -n foreman-docs-web-master
run: gh run download '${{ github.event.worfklow_run.id }}' -n 'foreman-docs-html-${{ fromJSON(env.PR_DATA).branch_name }}' -n foreman-docs-html-base -n foreman-docs-web-master

- name: Set preview domain
run: echo "PREVIEW_DOMAIN=$(echo ${{ github.repository }} | tr / - )-${{ github.job }}-pr-${{ fromJSON(env.PR_DATA).pr_number }}.surge.sh" >> $GITHUB_ENV
Expand Down

0 comments on commit 71b5724

Please sign in to comment.