Optimize the diff text when there's no change #3036
Conversation
|
The PR preview for 3b74f72 is available at theforeman-foreman-documentation-preview-pr-3036.surge.sh The following output files are affected by this PR: |
This suggests it's not working as intended, but the workflow runs after |
pr-processor
bot
added
Waiting on contributor
|
When testing the implementation appeared to have an issue, so I need to dive into it a bit more. Though perhaps that was in the other repo I was playing with |
|
triage: @ekohl friendly reminder |
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
If a PR doens't generate a diff (like this change) then the message shouldn't link to any diffs. By making this message explicit it makes reviewing a bit easier.
|
I've fixed the |
| @@ -68,8 +68,10 @@ jobs: | |||
| - name: Create diff to old base | |||
| run: | | |||
| diff -Nrwu old/ preview/${{ fromJSON(env.PR_DATA).target_name }}/ | cat > preview/diff.patch | |||
| pygmentize -o preview/diff.html -l diff -f html -O full preview/diff.patch | |||
| diffstat -l -p2 preview/diff.patch > diff.txt | |||
| if [[ -s preview/diff.patch ]] ; then | |||
There was a problem hiding this comment.
Potential performance improvement: only install diffstat python3-pygments if there is a diff.
If a PR doens't generate a diff (like this change) then the message shouldn't link to any diffs. By making this message explicit it makes reviewing a bit easier.
Please cherry-pick my commits into: