Drop mentions of --foreman-proxy-register-in-foreman #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am cool w/o a migration. |
ekohl
changed the title
Lennonka
requested changes
Jun 19, 2024
Comment on lines
+58
to
+59
| When network connections or ports to {Project} are not yet open, registration of the {SmartProxy} will fail. | ||
| Correctly configure the network and firewalls before rerunning the installer. |
There was a problem hiding this comment.
This should be covered in Prerequisites. It may need a different wording.
There was a problem hiding this comment.
I was thinking about the same thing.
| When network connections or ports to {Project} are not yet open, registration of the {SmartProxy} will fail. | ||
| Correctly configure the network and firewalls before rerunning the installer. |
pr-processor
bot
added
Waiting on contributor
ekohl
commented
Jun 19, 2024
| @@ -38,7 +38,6 @@ Retain a copy of the `{foreman-installer}` command that the `{certs-generate}` c | |||
| _output omitted_ | |||
| {installer-scenario-smartproxy} \ | |||
| --certs-tar-file "/root/{smart-proxy-context}_cert/_{smartproxy-example-com}_-certs.tar" \ | |||
| --foreman-proxy-register-in-foreman "true" \ | |||
There was a problem hiding this comment.
This is actually command output and comes from https://github.com/theforeman/foreman-installer/blob/2ec4fbdac78e208dbe83dc9414f73ab0dd60ee69/katello_certs/hooks/boot/02-message-helpers.rb#L60 so I think this particular line needs to be kept in until we drop it from the installer.
|
Moving back to draft because it needs some installer work as well before we can proceed. |
ekohl
force-pushed
the
drop-register-in-foreman
branch
from
b50a399 to
324d5a4
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
|
Trivial rebase without any content changes just so I could test previews after I made changes there. |
ekohl
force-pushed
the
drop-register-in-foreman
branch
from
324d5a4 to
4743e08
Compare
By removing mentions of this, it becomes an unsupported feature. This is good because various parts of the documentation assume it's turned on. Users can easily get into unexpected errors way further down the line if they disable this feature. Where there were explicit instructions to disable it, the text is changed into troubleshooting.
ekohl
force-pushed
the
drop-register-in-foreman
branch
from
4743e08 to
5db7c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing mentions of this, it becomes an unsupported feature. This is good because various parts of the documentation assume it's turned on. Users can easily get into unexpected errors way further down the line if they disable this feature.
Where there were explicit instructions to disable it, the text is changed into troubleshooting.
I'd appreciate some feedback on the phrasing of the changed lines.
Please cherry-pick my commits into: