Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dollar sign prefix for variables for GHA #3586

Closed

Conversation

maximiliankolb
Copy link
Contributor

rg "\{\{" .github

What changes are you introducing?

add missing dollar signs

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

to make GH previews work again 🤞

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

no cherry-picks

$ rg "\{\{" .github

Refs 242dde2 (PR 3579 on GitHub)
Refs 313e77e (PR 3584 on GitHub)
@ekohl
Copy link
Member

ekohl commented Jan 17, 2025

In #3587 I tried this too, but quoted to be sure it's a single argument and also tried the download of multiple at the same time. Not sure what you prefer.

@maximiliankolb
Copy link
Contributor Author

In #3587 I tried this too, but quoted to be sure it's a single argument and also tried the download of multiple at the same time. Not sure what you prefer.

Quoting probably makes sense -> closing this PR.

@maximiliankolb maximiliankolb deleted the missing_dollar_sign branch January 17, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants