Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT-30004 - Fix Actions History to correctly show tasks instead of nil #938

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

chris1984
Copy link
Member

Before:
before

After:
after

@lfu
Copy link
Collaborator

lfu commented Jan 15, 2025

It does fix the reported issue.

Since the first run took a while so I took a peek at foreman's log. It was flooded with:

17:30:30 rails.1   | 2025-01-15T17:30:30 [I|app|ebcd3b4b] Processing by ForemanInventoryUpload::ReportsController#last as JSON
17:30:30 rails.1   | 2025-01-15T17:30:30 [I|app|ebcd3b4b]   Parameters: {"organization_id"=>"1"}
17:30:30 rails.1   | 2025-01-15T17:30:30 [I|app|ebcd3b4b] Completed 200 OK in 8ms (Views: 0.6ms | ActiveRecord: 1.3ms | Allocations: 4098)
17:30:30 rails.1   |  ebcd3b4b | 
17:30:30 rails.1   |  ebcd3b4b | 
17:30:32 rails.1   | 2025-01-15T17:30:32 [I|app|0861c0c5] Started GET "/foreman_inventory_upload/accounts" for 10.22.65.146 at 2025-01-15 17:30:32 -0500
17:30:32 rails.1   | 2025-01-15T17:30:32 [I|app|0861c0c5] Processing by ForemanInventoryUpload::AccountsController#index as JSON
17:30:32 rails.1   | 2025-01-15T17:30:32 [I|app|0861c0c5] Completed 200 OK in 9ms (Views: 0.2ms | ActiveRecord: 1.7ms | Allocations: 4508)
17:30:32 rails.1   |  0861c0c5 | 
17:30:32 rails.1   |  0861c0c5 | 
17:30:34 rails.1   | 2025-01-15T17:30:34 [I|app|190aaa07] Started GET "/foreman_inventory_upload/1/reports/last" for 10.22.65.146 at 2025-01-15 17:30:34 -0500
17:30:34 rails.1   | 2025-01-15T17:30:34 [I|app|190aaa07] Processing by ForemanInventoryUpload::ReportsController#last as JSON
17:30:34 rails.1   | 2025-01-15T17:30:34 [I|app|190aaa07]   Parameters: {"organization_id"=>"1"}
17:30:34 rails.1   | 2025-01-15T17:30:34 [I|app|190aaa07] Completed 200 OK in 9ms (Views: 0.8ms | ActiveRecord: 2.1ms | Allocations: 4098)
17:30:34 rails.1   |  190aaa07 | 
17:30:34 rails.1   |  190aaa07 | 

And it runs non-stop. I restarted the foreman server and it's keeping flooded with these messages without me doing anything.
Is this something we are aware of?

@chris1984
Copy link
Member Author

It does fix the reported issue.

Since the first run took a while so I took a peek at foreman's log. It was flooded with:

17:30:30 rails.1   | 2025-01-15T17:30:30 [I|app|ebcd3b4b] Processing by ForemanInventoryUpload::ReportsController#last as JSON
17:30:30 rails.1   | 2025-01-15T17:30:30 [I|app|ebcd3b4b]   Parameters: {"organization_id"=>"1"}
17:30:30 rails.1   | 2025-01-15T17:30:30 [I|app|ebcd3b4b] Completed 200 OK in 8ms (Views: 0.6ms | ActiveRecord: 1.3ms | Allocations: 4098)
17:30:30 rails.1   |  ebcd3b4b | 
17:30:30 rails.1   |  ebcd3b4b | 
17:30:32 rails.1   | 2025-01-15T17:30:32 [I|app|0861c0c5] Started GET "/foreman_inventory_upload/accounts" for 10.22.65.146 at 2025-01-15 17:30:32 -0500
17:30:32 rails.1   | 2025-01-15T17:30:32 [I|app|0861c0c5] Processing by ForemanInventoryUpload::AccountsController#index as JSON
17:30:32 rails.1   | 2025-01-15T17:30:32 [I|app|0861c0c5] Completed 200 OK in 9ms (Views: 0.2ms | ActiveRecord: 1.7ms | Allocations: 4508)
17:30:32 rails.1   |  0861c0c5 | 
17:30:32 rails.1   |  0861c0c5 | 
17:30:34 rails.1   | 2025-01-15T17:30:34 [I|app|190aaa07] Started GET "/foreman_inventory_upload/1/reports/last" for 10.22.65.146 at 2025-01-15 17:30:34 -0500
17:30:34 rails.1   | 2025-01-15T17:30:34 [I|app|190aaa07] Processing by ForemanInventoryUpload::ReportsController#last as JSON
17:30:34 rails.1   | 2025-01-15T17:30:34 [I|app|190aaa07]   Parameters: {"organization_id"=>"1"}
17:30:34 rails.1   | 2025-01-15T17:30:34 [I|app|190aaa07] Completed 200 OK in 9ms (Views: 0.8ms | ActiveRecord: 2.1ms | Allocations: 4098)
17:30:34 rails.1   |  190aaa07 | 
17:30:34 rails.1   |  190aaa07 | 

And it runs non-stop. I restarted the foreman server and it's keeping flooded with these messages without me doing anything. Is this something we are aware of?

If you stay on the inventory page it does spam what you are seeing. I stayed on this page https://ip-10-0-167-73.rhos-01.prod.psi.rdu2.redhat.com/foreman_rh_cloud/inventory_upload and opened actions histories in a new tab. Once I closed inventory_upload the spam went away.

Not related to this PR but I can raise a Jira for it so we can investigate.

@chris1984 chris1984 merged commit d629833 into theforeman:develop Jan 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants