Rewrite Foreman's stable job testing to a pipeline #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the last manual action on branching. This is now possible because every version is included verbatim instead of sometimes having an underscore in it.
ehelms
reviewed
Jan 15, 2025
| TESTOPTS = '-v' | ||
| } | ||
|
|
||
| matrix { |
There was a problem hiding this comment.
I think this has to be a child of at least a stages-stage declaration:
stages {
stage('') {
matrix {
ehelms
reviewed
Jan 15, 2025
| @@ -0,0 +1,64 @@ | |||
| pipeline { | |||
There was a problem hiding this comment.
I think tihs top level pipeline needs an agent declaration:
pipeline {
agent none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes inspiration from #523 and makes life better by being consistent. That consistency also removes a step in the branching procedure (and clean up later on when a version is dropped).