Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ansible diff mode #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rpluem-vf
Copy link

Add the possibility to turn on Ansible diff mode by the new input parameter diff_mode.
There will be further PR's following to https://github.com/theforeman/foreman-ansible-modules and https://github.com/theforeman/foreman_ansible to enable this on the Foreman server and make use of it in the configuration reports.

Add the possibility to turn on Ansible diff mode by the new input parameter
diff_mode.

Signed-off-by: Ruediger Pluem <ruediger.pluem@vodafone.com>
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance this looks good, waiting for the followup PRs in related repos.

lib/smart_proxy_ansible/runner/ansible_runner.rb Outdated Show resolved Hide resolved
Co-authored-by: Adam Růžička <adamruzicka@users.noreply.github.com>
@rpluem-vf
Copy link
Author

Next PR is theforeman/foreman-ansible-modules#1816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants