Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix position of the AOTF header in narrow windows #22

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix position of the AOTF header in narrow windows #22

merged 1 commit into from
Feb 15, 2024

Conversation

fedde-s
Copy link
Member

@fedde-s fedde-s commented Feb 15, 2024

No description provided.

@fedde-s fedde-s requested a review from RobinM-code February 15, 2024 15:18
@fedde-s
Copy link
Member Author

fedde-s commented Feb 15, 2024 •
edited
Loading

@RobinM-code, the top: 0px overrides the top: 50px that gets applied for wider viewport sizes. In that case the AOTF table header sticks to the top of the viewport, but shouldn't be hidden behind the custom top bar. In narrow windows, the @media block I add to here comes into effect, to activate a scroll inside the table.

@fedde-s fedde-s merged commit 329cd4e into v0.6.7/thehyve Feb 15, 2024
3 checks passed
@fedde-s fedde-s deleted the fix-top-bar-aotf-page-responsiveness branch February 15, 2024 16:02
ricardo-lourenco pushed a commit that referenced this pull request Mar 27, 2024
@fedde-s @ricardo-lourenco
Fix position of the AOTF header in narrow windows (#22)
3d3630d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinM-code RobinM-code RobinM-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedde-s @RobinM-code