Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature remove index.php in the url and auto redirect http -> https #34

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LucasCRENAIS
Copy link

No description provided.

@gillesbourgeat gillesbourgeat marked this pull request as draft May 31, 2021 15:29
Config/config.xml Outdated Show resolved Hide resolved
Config/config.xml Outdated Show resolved Hide resolved
Controller/Admin/ModuleConfigController.php Outdated Show resolved Hide resolved
Controller/Admin/ModuleConfigController.php Outdated Show resolved Hide resolved
Controller/Admin/ModuleConfigController.php Outdated Show resolved Hide resolved
EventListeners/RequestListener.php Outdated Show resolved Hide resolved
EventListeners/RequestListener.php Outdated Show resolved Hide resolved
EventListeners/RequestListener.php Outdated Show resolved Hide resolved
Config/config.xml Outdated Show resolved Hide resolved
EventListeners/RequestListener.php Outdated Show resolved Hide resolved
EventListeners/RequestListener.php Outdated Show resolved Hide resolved
@gillesbourgeat gillesbourgeat changed the title autoindex.php Addition of the feature remove index.php in the url and auto redirect http -> https Jun 7, 2021
@gillesbourgeat gillesbourgeat changed the title Addition of the feature remove index.php in the url and auto redirect http -> https Add feature remove index.php in the url and auto redirect http -> https Jun 7, 2021
Comment on lines +16 to +28

<!-- INDEX-REDIRECTION-ENABLE ROUTE -->
<route id="rewrite.url.config.set-index-redirection_enable" path="/admin/module/RewriteUrl/config/setIndexRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setIndexRedirectionEnableAction</default>
</route>
<!-- ############################# -->

<!-- HTTPS-REDIRECTION-ENABLE ROUTE -->
<route id="rewrite.url.config.set-https-redirection_enable" path="/admin/module/RewriteUrl/config/setHttpsRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setHttpsRedirectionEnableAction</default>
</route>
<!-- ############################# -->

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- INDEX-REDIRECTION-ENABLE ROUTE -->
<route id="rewrite.url.config.set-index-redirection_enable" path="/admin/module/RewriteUrl/config/setIndexRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setIndexRedirectionEnableAction</default>
</route>
<!-- ############################# -->
<!-- HTTPS-REDIRECTION-ENABLE ROUTE -->
<route id="rewrite.url.config.set-https-redirection_enable" path="/admin/module/RewriteUrl/config/setHttpsRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setHttpsRedirectionEnableAction</default>
</route>
<!-- ############################# -->
<route id="rewrite.url.config.set-index-redirection_enable" path="/admin/module/RewriteUrl/config/setIndexRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setIndexRedirectionEnableAction</default>
</route>
<route id="rewrite.url.config.set-https-redirection_enable" path="/admin/module/RewriteUrl/config/setHttpsRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setHttpsRedirectionEnableAction</default>
</route>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants