Implemented support for creating neogma models with decorators #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themetalfleece
requested changes
Aug 9, 2023
There was a problem hiding this comment.
Spectacular work, looking forward to this being merged! 🚀
I've added a few comments, mostly related to code and types, as I don't have the time to test its functionality. However, since you've added tests, it works out great.
Some of my comments are in the form of questions and might not be relevant, but in this case please reply them so I'm aware of whatever I'm missing :)
Again, this is amazing!!
…d setter args Co-authored-by: Jason Athanasoglou <jathanasoglou@outlook.com>
Co-authored-by: Jason Athanasoglou <jathanasoglou@outlook.com>
|
Hi all! I am looking forward to this PR, are there any updates on this? |
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.