Skip to content

Commit

Permalink
[SDK] Fix: Remove auth from useConnectModal props as it's not current…
Browse files Browse the repository at this point in the history
…ly supported (#5618)

Fixes #5615

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on removing the `auth` property from the `useConnectModal` options in the `thirdweb` package, as it is currently unsupported.

### Detailed summary
- Removed the `auth` property from `UseConnectModalOptions` in `packages/thirdweb/src/react/web/ui/ConnectWallet/useConnectModal.tsx`.
- Updated documentation to reflect the removal of the `auth` prop.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
  • Loading branch information
gregfromstl committed Dec 4, 2024
1 parent 1a2390b commit 33c23e7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
5 changes: 5 additions & 0 deletions .changeset/tidy-zoos-know.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Fix: Removed the auth prop from useConnectModal as it is currently not supported
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import type { Wallet } from "../../../../wallets/interfaces/wallet.js";
import type { SmartWalletOptions } from "../../../../wallets/smart/types.js";
import type { AppMetadata } from "../../../../wallets/types.js";
import type { Theme } from "../../../core/design-system/index.js";
import type { SiweAuthOptions } from "../../../core/hooks/auth/useSiweAuth.js";
import { SetRootElementContext } from "../../../core/providers/RootElementContext.js";
import { WalletUIStatesProvider } from "../../providers/wallet-ui-states-provider.js";
import { canFitWideModal } from "../../utils/canFitWideModal.js";
Expand Down Expand Up @@ -433,14 +432,6 @@ export type UseConnectModalOptions = {
* If you want to hide the branding, set this prop to `false`
*/
showThirdwebBranding?: boolean;

/**
* Enable SIWE (Sign in with Ethererum) by passing an object of type `SiweAuthOptions` to
* enforce the users to sign a message after connecting their wallet to authenticate themselves.
*
* Refer to the [`SiweAuthOptions`](https://portal.thirdweb.com/references/typescript/v5/SiweAuthOptions) for more details
*/
auth?: SiweAuthOptions;
};

// TODO: consilidate Button/Embed/Modal props into one type with extras

0 comments on commit 33c23e7

Please sign in to comment.