Skip to content

Commit

Permalink
fix(deploy): add missing version argument in computeDeploymentInfoFro…
Browse files Browse the repository at this point in the history
…mContractId function (#3769)

Fix deterministic deploys with specified versions by adding the 'version' argument to the 'computeDeploymentInfoFromContractId' function.

---

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on fixing deterministic deploys with specified versions in the `compute-published-contract-deploy-info.ts` file under `thirdweb` package.

### Detailed summary
- Added `version` field to `computePublishedContractDeployInfo` function parameters.
- Utilizes the specified version for deterministic deployments.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
  • Loading branch information
gregfromstl committed Jul 22, 2024
1 parent 3de2dce commit a9a3f0f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/large-cycles-joke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Fix deterministic deploys with specified versions
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export async function computeDeploymentInfoFromContractId(args: {
client,
contractId,
publisher: args.publisher,
version: args.version,
});
return computeDeploymentInfoFromMetadata({
client,
Expand Down

0 comments on commit a9a3f0f

Please sign in to comment.