Skip to content

Commit

Permalink
[TOOL-2999] SDK: automatically sign message for SIWE in connect UI fo…
Browse files Browse the repository at this point in the history
…r Ecosystem wallets (#5914)

---
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
---

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.

## How to test
Unit tests, playground, etc.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the `SignatureScreen` component by updating the signing flow for different wallet types and enhancing the user experience by removing unnecessary prompts for signing messages.

### Detailed summary
- Added `isHeadlessSignSupported` function to determine wallet support.
- Updated `SignatureScreen` logic to handle headless signing for supported wallets.
- Refactored tests to improve clarity and organization.
- Enhanced error handling and loading states in the UI.
- Introduced mocks for `useActiveWallet` and `useAdminWallet` in tests.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
  • Loading branch information
MananTank committed Jan 9, 2025
1 parent b14aa54 commit c5c6f9d
Show file tree
Hide file tree
Showing 3 changed files with 238 additions and 173 deletions.
5 changes: 5 additions & 0 deletions .changeset/six-snails-reflect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Do not prompt user for signing message for SIWE auth in Connect UI for Ecosystem wallets
Loading

0 comments on commit c5c6f9d

Please sign in to comment.